Merged
Conversation
This based on doorkeeper#19. The PR has been open for over a year, with no perceived movement, so instead we'll update our fork of event_tracker to the latest and include this PR's contents.
achpsident
force-pushed
the
feature/add_google_analytics4_support
branch
from
989fbf6 to
da50f90
Compare
achpsident
force-pushed
the
feature/add_google_analytics4_support
branch
2 times, most recently
from
ec1e068 to
dce3d2d
Compare
yemartin
requested changes
Aug 22, 2024
|
|
||
| def track(event_name, properties = {}) | ||
| %Q{ga('event_tracker.send', 'event', 'event_tracker', '#{event_name}');} | ||
| properties_js = properties.to_json |
Member
There was a problem hiding this comment.
I'd call the temp properties_json for consistency.
But remember the refactoring pair: Inline Temp vs. Introduce Explanatory Variable. And properties_json isn't really doing any explaining compared to properties.to_json.
So... Inline Temp?
Author
yemartin
approved these changes
Aug 22, 2024
Unfortunately, it appears as if the tentative PR that added Google Analytics 4 neglected to properly load gtag. This commit fixes the problem.
achpsident
force-pushed
the
feature/add_google_analytics4_support
branch
from
4bbc7ad to
db63627
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on doorkeeper#19. The PR has been open for over a year, with no perceived movement, so instead we'll update our fork of event_tracker to the latest and include this PR's contents.